Repository navigation
Migrate shared Devices.ServiceAnnouncement directives to v3 wrappers - #3866
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
Conversation
Review both profiles against actual legacy operation IDs and compatible method/path counterparts. Preserve authoritative v1.0 derived names while covering beta suppressions and Admin prefix removal. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota 1.36.1 and wrapper Release generation against the compatible v1.0 spec. Client/cmdlet sources and projects are unchanged; only the actual Kiota tool version changes in the lock file. Compiled manifest exports 30 cmdlets. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota 1.36.1 and wrapper Release generation against the compatible beta spec. Preserve committed Beta casing, suppress reviewed write/root/adminUnits operations and remove Admin from surviving nouns. Compiled manifest exports 30 cmdlets; client/project sources are unchanged apart from lock evidence. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…z-serviceannouncement-v3-migration
Use current supported literal mappings after proving complete original legacy/current selector equality: 22 v1.0 and 31 beta suppressions. Keep both-side action/function proof for the nine final beta namespace translations in notes and regression tests; preserve all earlier migration and generation commits. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota 1.36.1 and wrapper Release pipeline against aligned/refreshed spec blob66bc6a0aaa679f286420bef098c24b3237713163. Compiled output exports30 cmdlets across25exact surviving routes and5dispatchers; v1.0 oracle parity25/25. Generated source and projects remain unchanged; only the actual client description hash changes. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full queued Kiota 1.36.1 and wrapper Release pipeline against aligned/refreshed spec blobccb85afb6e58981eace70039d057557b427cf45a. Compiled output exports30 cmdlets across25exact surviving routes and5dispatchers, with all31selected suppressions absent. Generated source and projects remain unchanged; only the actual client description hash changes. Preserve existing Beta output casing and baseline naming limitations. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Ramses Sanchez-Hernandez (ramsessanchez)
requested a review
from a team
as a code owner
October 27, 2026 19:05
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Pass explicit runtime profile context to naming and suppression calls and cover derived naming both enabled and disabled. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…dation Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full compatible Kiota/client/cmdlet/project/manifest regeneration after #3891. Emit explicit v1.0 transport context and let Authentication own all shared dependencies. Normal-manifest offline authenticated Global/USGov probes pass all25 routes, five dispatchers and six typed actions with WhatIf and genuine declined confirmation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full compatible Kiota/client/cmdlet/project/manifest regeneration after #3891. Emit explicit beta transport context and keep only owned wrapper DLLs. Global/USGov real authenticated offline probes pass all25 routes, five dispatchers, six typed actions and genuine declined confirmation without changing shared HttpClient BaseAddress. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Run full compatible Kiota/client/cmdlet/project/manifest generation on merged #3886. Preserve25surviving GET/action routes and normal Authentication ownership. Fresh Global/USGov compiled probes pass43offlineauthenticatedrequests each, typedPOSTs, native optional queries, cache/session lifecycle and genuine No/WhatIf safety. Client/project/locks remain byte-identical; only generated path-ID validation annotations change. No PATCH survives original suppression policy. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Full queued compatible Kiota/client/cmdlet/project/manifest generation on merged #3886, with43authenticatedoffline requests per Global/USGov memory-guarded proof. Six typedJSON actions, profiles/cache/session lifecycle, optional nativequeries and genuineNo/WhatIf pass. No PATCH or required query survives original shared suppressions. Both final profile source deltas are15generated blank lines only; clients/projects/locks are byte-identical. This clarifies the prior v1 boundary body's inaccurate reference to path-ID annotations; no such validation behavior changed. Preserve every prior commit without amendment. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N/A - no linked issue.
Changes proposed in this pull request
Devices.ServiceAnnouncement.mdcmdlet directives: suppress 22 v1.0 and 31 beta operations, and removeAdminfrom the 25 surviving service-announcement operation nouns in each profile. Preserve authoritative derived v1.0 names/verbs. Complete original same-profile legacy/current selector equality is tested, including the nine beta final action/function qualifier translations with matching parents, methods and kind metadata. Ordinary finite literal mappings remain fully Mapped; no Legacy helper/schema fields or API-absence assertion are introduced.powershell-v3target6475f3f5beb4908d39ea356db32bf1e0fd3273cbafter Remove automatic GET after successful PATCH #3886, preserving all prior migration/API/profile-generation commits. Fully regenerate and build v1.0 THEN beta through the unchanged queue. Both normal manifests export 30 cmdlets: exactly 25 surviving method/path routes plus five dispatchers. Profile context remains separate from shared authored configuration and the three GeneratorConfig run settings.src/readme.graph.mdremain ignored and untouched. Parameter aliases/transforms and schema/response classes remain deferred; neither class occurs in this shared module file. No naming sweep, unsupported selector, unmerged Fix Kiota PostPath typed navigation without renaming operation types #3881 overlay, issue [v3 wrappers] Support arbitrary optional query parameters #3897 implementation, Auth/runtime/template change, shim, dependency copy or PR merge is included.Final target and history
Current normal base is
6475f3f5beb4908d39ea356db32bf1e0fd3273cb. Normal merge is6e0226bc3770382e76c844fe4e0380df36f30894. Separate final combined generation boundaries are v1.0bd5c7ce9209a76d7a5c14583fcdc8879114a904eand beta/current head966b13b56d3142725603893652c73abfbaf62249.Both boundaries represent actual full compatible Kiota/client/cmdlet/project/manifest runs. Clients, projects and locks are byte-identical; each committed source delta is 15 generated blank lines only. There is no API or validation behavior change in those deltas. The v1 commit body incorrectly calls these path-ID annotations; the beta body corrects that description without amending history. Normal regenerated manifests and compiled binaries remain uncommitted validation outputs with hashes in the evidence.
Original migration
004fe9c40d, original v1/beta generations61acd7d2aa/b840d8ae48, earlier integration8f6ee2a73c, ledger correction04857b0df6, generation boundarieseaa3d54beb/132fe6469c, #3849 integrationafb90a263eand API correction1f63f474c0, #3891 integration755d93d08cand generations356f8d6b3a/5ed0976201all remain intact. No rebase, amend, force push, new PR, readiness change or automatic merge was performed. Full uncapped Git diff review covers 99 changed/renamed/deleted entries against the current target, all module-owned or its companion test; no bin/obj/DLL/nupkg/log/session artifacts are committed.PATCH and required-query applicability
The actual effective compatible specs contain 47 v1.0 operations and 56 beta operations. Original shared suppression removes 22/31, leaving exactly 19 GET and six POST action operations in each profile. Every PATCH is suppressed, and no required query parameter survives. The OpenAPI reader explicitly resolves operation/path parameter precedence and references before counting. Thus module PATCH204/PATCH200 and mandatory Query transport gates are not applicable, not waived failures or missing APIs; no mutation is invented. Current combined source tests also cover the merged no-readback and required-query framework contracts.
The current framework contract is PATCH204: one PATCH, no object, no automatic GET; PATCH200 returns its own typed model without a readback. Explicit GET is caller-controlled and has independent inputs. There is no PassThru/ReadBack/Refetch switch. This PR does not restore the superseded implicit-GET behavior.
Final full generation, tests and strict inventory
Fresh full v1.0 generation/build: exit 0 / OK / 116.40 seconds / 30 compiled exports. Fresh full beta: exit 0 / OK / 122.60 seconds / 30 exports. Builder module times exclude queue waiting. Both used the unchanged four-mutex queue, compatible specs, isolated Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943 and process-local cap 1, .NET SDK 10.0.403 and PowerShell 7/Core. No SkipKiota, GenerateOnly, NoCollisionData, fallback spec or NO-CMDLETS result qualifies.
Compatible-spec Git blobs remain v1.0
66bc6a0aaa679f286420bef098c24b3237713163, betaccb85afb6e58981eace70039d057557b427cf45a. Original/current source/spec Git blobs and SHA256s are retained.Exact full commands, with process-local environment set in the same invocation:
Both commands passed as reported above. The later memory-only probe correction did not rerun or relabel these builds.
Results: 166 executed / 166 passed / 0 failed / 0 not executed, verified scalar TRX counters, exit 0. Strict inventory passed, two rows / two Mapped / zero Deferred or Unresolved; suppression 22/31 and rename 25/25 remain exact. Source scope reader passed with the actual method/query counts above. Initial scope-helper setup errors are preserved separately and are not represented as successful production validation. No stability-sensitive inventory framework test ran concurrently with commits. No source, test, generator or full-generation rerun was needed for the subsequent probe-isolation correction.
Corrected runtime isolation and real transport acceptance
Normal Authentication OnImport into the confirmation-host runspace resets the shared datastore to DiskDataStore. An earlier MockDataStore assignment alone is insufficient. New corrected scripts/results are in the separate memory-final folder; earlier unguarded v1 runtime evidence remains untouched and is not labeled newly isolated. A DiskDataStore type alone does not establish that credential I/O occurred.
The corrected gate imports the additional runspace BEFORE Connect, then reapplies the existing repository Set-MgTestDataStore helper. It reflects the actual shared GraphSession.DataStore type and records
Microsoft.Graph.Authentication.Test.Mocks.MockDataStorebefore Connect, every production transport invocation, request-context change, reconnect and logout, and after lifecycle operations. Every terminal HTTP capture independently asserts and records that actual type. Source paths and SHA256s of the unchanged helper and MockDataStore implementation are included.All four corrected cases passed, exit 0, against the same valid full-build outputs. Each fresh normal-manifest import verifies 30 exports, exact 25 surviving GraphRoute method/path pairs, five dispatcher defaults/alternatives/path-ID sets, all suppressions absent, retained neighbors and normal assembly ownership.
Each case exercises 43 real authenticated offline requests: 19 typed GET workers, ten public dispatcher list/item calls, six typed POST actions, one representative adapter-reuse read, one optional native-query encoding read, four alternating v1/beta cached reads, and request-context/reconnect reads. All six actions verify exact method/escaped URI, application/json messageIds values, generic marker/If-Match headers and actual declared typed boolean results. Native optional $top/$filter/$select values round-trip without public Query prefixes on the wire.
Each case also passes six WhatIf zero-HTTP checks, six genuine No zero-HTTP confirmations with exactly one prompt each, 30 unknown-selector and five incompatible list/item binding rejections before HTTP, adapter reuse, client/profile cache separation, request-context invalidation, reconnect token/client/adapter replacement and disconnect NoGraphSession/zero-HTTP behavior.
Transport uses real Connect-MgGraph and GraphHttpClientFactory authentication with only a test terminal capture handler. Actual selected service roots are graph.microsoft.com/v1.0, graph.microsoft.com/beta, graph.microsoft.us/v1.0 and graph.microsoft.us/beta. The factory's global/v1.0 HttpClient BaseAddress remains unmodified; beta/cloud URIs are correct. All 172 final requests are offline; no live Graph/OAuth requests are made. Normal manifests/bins are accepted, not a tiny fixture surface.
The exact adapted normal Authentication 2.41.2 package is used, not stock gallery 2.41.2 or old 2.38.1. All 64 file hashes and physical nupkg SHA256
2FC09BFE6B70D313BC56DF8ADCCFB1976FB4E90A1898BF8A916B4B8B792898EBare verified. Shipping Auth/runtime/templates remain source-equivalent to the verified normal package. Wrapper bins contain exactly their three owned DLLs; manifests require Authentication 2.41.2 with no RequiredAssemblies. Single Authentication/Kiota/RMS/UriTemplate/Multipart identities, package paths, load contexts, manifest and binary hashes are recorded. No production Auth, loader, dependency closure, OnImport, provider or package was changed for the memory guard.Raw parity and retained limits
v1.0 raw parity passed, exit 0, 30/30 rows. Beta remains the documented baseline exit 1, 0/30 raw matches: 22 missing-Beta-prefix-only rows and eight existing action/report verb/word-order differences, including five dispatcher rows in the tool's population. No prefix normalization is presented as raw success; profile-local naming remains out of scope. Existing NU1903 YamlReader 3.7.0 warnings remain unrelated. Full-repository tests, live tenant certification, PowerShell 5.1 and separate wrapper nupkg packing were not performed.
Canonical evidence
Build/tests/source:
C:\Users\ramsess\.copilot\session-state\fc5ca4bc-3f4f-41c0-8746-372f984c06f7\files\post3886-6475-final\contains rawfull-v1.0.log/.exit,full-beta.log/.exit, Kiota logs,targeted.trx,targeted-tests.log/.exit,strict-inventory.json, actualspec-scope.json, original/current input/spec/Auth64/nupkg/queue/tool identities, final generated-source hashes and generation boundary identifiers.New guarded runtime/canonical handoff:
C:\Users\ramsess\.copilot\session-state\fc5ca4bc-3f4f-41c0-8746-372f984c06f7\files\post3886-6475-memory-final\contains the corrected probe, fourcompiled-<profile>-<cloud>.json/.log/.exitcases with exact actual HTTP captures and datastore/source/context/hash checks,runtime-correction-provenance.json, preserved old-proof identities, full uncapped Git scope, canonical scalarhandoff.json, its SHA256 and an absolute artifact-path/SHA256 index. It references the unchanged valid earlier build/TRX artifacts; those are not relabeled as memory reruns.Older #3849/#3891 evidence, actual historical RMS failures, intermediate unguarded runtime evidence and prior PR bodies remain preserved. The historical RMS serialization gap is resolved by normal Authentication packaging, not by a module workaround.
Other links